SAS transport data source

RE: SAS transport data source

Hi Andrew,

 

Looking at the code, I believe that you're correct. If you'd like to submit a fix, you can send it to me, otherwise I'll take care of it while performing updates. In either case, the issue will be resolved for the 1.1 release.

 

Sorry for the delayed response, and thank you for the feedback!

 

Regards,

Tim

RE: SAS transport data source

There are different ways of fixing this, so I'll leave it to you - it will be cleaner that way. As an aside, I came across this while writing a SAS transport writer integrated with the openCDISC API. Would this be a component you'd be interested in?

 

cheers,

Andrew

RE: SAS transport data source

Hi Andrew,

 

Alright, sounds good. As far as your SAS transport writer is concerned, that's something I'd like to hear more about.

 

Regards,

Tim

RE: SAS transport data source

Hi Tim,

 

Sorry - didn't mean to be obtuse but I haven't seen a way to upload patches/files. Below is what I did to flag up empty spaces. But I think it was late or my brain was just not working, so there is something ugly about my solution. :-)

Re SAS writer, is there somewhere I can post it? It's still rough round the edges - just a test really - but you're welcome to have a gander.

 

cheers,

Andrew

//SasTransportDataSource parseRecords

//Before checking if it has a value and doing double conversion

 

...

boolean isSpace = true;

for (int j = 0; j < dataBytes.length; ++j) {

if (dataBytes[j] != 0x20) {

isSpace = false;

}

if (dataBytes[j] != 0 && j > 0) {

hasValue = true;

if(dataBytes[j] != 0x20) {

break;

}

}

}

if (isSpace) {

hasValue = false;

}

 

...

//after doing double conversion

 

if (dataBytes[0] != 0 || isSpace) {

recordVariableValue = new DataEntry(null);

++nulls;

} else {

...

 

 

 

RE: SAS transport data source

Hi Andrew,

 

No need to apologise, we're admittedly not very equiped in that regard at the moment. We're working on improving the way that we process/organize feedback in the future, so presumably we'll have a system that's friendly to patch submissions and the like once that's taken care of.

 

In the mean time, I'll see if I can rig something up for you to share the SAS writer, and thanks for your patience-I haven't been as prompt as I would have liked to have been in replying.

 

Regards,

Tim